refactor: migrate WASignalGroup to TypeScript and remove deprecated files

[jlucaso1]

Moving WASignalGroup to src and translated to typescript.

Removed group.proto and GroupProtocol because this can be reused in the main file of WAProto.

[whiskeysockets-bot]

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@jlucaso1/Baileys#refactor-wasignalgroup-to-typescript
# YARN v2
yarn add @whiskeysockets/baileys@jlucaso1/Baileys#refactor-wasignalgroup-to-typescript

[jlucaso1]

what i mean with reusing proto types

[AstroXTeam]

Very much needed

[AstroXTeam]

But does it work?

[jlucaso1]

But does it work?

Preliminarily yes.
What i have tested:
Login -> Sending message to myself (with a patch in another PR, because the master branch has a bug) -> Sending and receiving message to a group. (using example.ts)
By the way, more tests are welcome

[AstroXTeam]

Any kind of performance improvements?

[jlucaso1]

Any kind of performance improvements?

The performance gains here is minimal. (dev experience is the bigger gain)
But the file size bundle of the library is lighter, because i removed unused .proto file and type definitions in the project. So this can be good to startup time. (the logic of the WAGroup is the same, i only ported to typescript)

[AstroXTeam]

I see no need of removing the proto because it's not packed in the npm release, a those files are used for development and are very important

[jlucaso1]

Yeah. Check the bundled files on npm: https://www.npmjs.com/package/baileys?activeTab=code
Basically i removed the WASignalGroup/GroupProtocol.js because is an js compiled .proto. We already cover this same functions in WAProto/index.js so is duplicated code.

[AstroXTeam]

ohh I see, very clever there, I thought it was 2 different protos

[purpshell]

looking good for now, great work!

[purpshell]

fix types and merge conflict

[AliAryanTech]

failed, App\node_modules\libsignal\src\crypto.js:11
throw TypeError(Expected Buffer instead of: ${value.constructor.name});
^

TypeError: Expected Buffer instead of: Object
at assertBuffer (C:\App\node_modules\libsignal\src\crypto.js:11:15)

[jlucaso1]

failed, App\node_modules\libsignal\src\crypto.js:11 throw TypeError(Expected Buffer instead of: ${value.constructor.name}); ^

TypeError: Expected Buffer instead of: Object at assertBuffer (C:\App\node_modules\libsignal\src\crypto.js:11:15)

can you provide an reproduction?

[jlucaso1]

Moved to draft to investigate the problem that @AliAryanTech has reported